Improve shared configuration syncing. #110
Merged
+146
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
force-pushed
the
shared_config_improvements
branch
4 times, most recently
from
426da51
to
c1c6f7f
Compare
- Improve code style to match `brew style` norms. - General code refactoring/cleanup. - Fail script on invalid parameters. - Provide custom handling for `.rubocop.yml` and `.ruby-version` from Homebrew/brew's repository. We want to match the RuboCop and (Portable) Ruby version (without revision) usage from there. - Ensure that this workflow is always tested (but PRs not created) when triggered by a pull request. - Check code style with `brew style` in CI.
MikeMcQuaid
force-pushed
the
shared_config_improvements
branch
from
c1c6f7f
to
716011f
Compare
Bo98
reviewed
May 24, 2024
Comment on lines
+7
to
+11
| Homebrew/MoveToExtendOS: | ||
| Enabled: true | ||
| Exclude: | ||
| - "{extend,test,requirements}/**/*" | ||
| - "os.rb" |
There was a problem hiding this comment.
A lot of this is intentionally Homebrew/brew specific like this cop (we don't want to block if OS.mac? in formulae etc). Is this the correct file?
The ../rubocop.yml isn't correct for any repository AFAIK, since if we're targeting Library/.rubocop.yml it should be ../../.. for taps (and nothing for non-taps).
There was a problem hiding this comment.
Yup, not correct, see #111 to fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylenorms..rubocop.ymland.ruby-versionfrom Homebrew/brew's repository. We want to match the RuboCop and (Portable) Ruby version (without revision) usage from there.brew stylein CI.